Use ZigbeeException instead of DeliveryError in ZHA#33993
Merged
springstan merged 2 commits intohome-assistant:devfrom Apr 11, 2020
Merged
Use ZigbeeException instead of DeliveryError in ZHA#33993springstan merged 2 commits intohome-assistant:devfrom
springstan merged 2 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
integration: zha
small-pr
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
dmulcahey
changed the title
dmulcahey
force-pushed
the
dm/zha-use-zigbee-exception
branch
from
210c4a2 to
ba50081
Compare
Member
|
Please solve the merge conflict so we can merge this PR :) |
dmulcahey
force-pushed
the
dm/zha-use-zigbee-exception
branch
from
ba50081 to
8e07eb4
Compare
Contributor
Author
|
@springstan fixed, still have codecov issues |
Member
|
I think codecoverage is ok for this change, because you only switch Exception types. |
Contributor
Author
your call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
In an earlier PR there was a comment made about DeliveryError: #33977 (comment) we discussed and decided that ZigbeeException should be used across the board in these cases. This PR makes the changes.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: