Cleanup ZHA group entity lifecycle#33977
Merged
balloob merged 3 commits intohome-assistant:devfrom Apr 10, 2020
Merged
Conversation
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
Adminiuga
approved these changes
Apr 10, 2020
| await self._zigpy_device.remove_from_group(group_id) | ||
| try: | ||
| await self._zigpy_device.remove_from_group(group_id) | ||
| except (zigpy.exceptions.DeliveryError, asyncio.TimeoutError) as ex: |
Contributor
There was a problem hiding this comment.
I'm on the fence whether we should use zigpy.exceptions.ZigbeeException instead of DeliveryError here. DeliverError is raised when the delivery fails (doh) but if usb port is disconnected or bellows is restarting it is going to be a different exception and either way any of those exceptions means the device hasn't received the request.
balloob
pushed a commit
that referenced
this pull request
Apr 10, 2020
* Clean up ZHA group entity lifecycle * group entities don't use state restore * add tests
Merged
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
No
Proposed change
This PR closes some holes in the ZHA group entity lifecycle. The PR does the following:
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: