Skip to content

Fix turning off/on light groups in homekit#33966

Closed
bdraco wants to merge 1 commit into
home-assistant:devfrom
bdraco:multiple_aid_homekit_service_callbacks
Closed

Fix turning off/on light groups in homekit#33966
bdraco wants to merge 1 commit into
home-assistant:devfrom
bdraco:multiple_aid_homekit_service_callbacks

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 10, 2020

Proposed change

  • Bump HAP-python to 2.8.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added integration: homekit small-pr PRs with less than 30 lines. dependency Pull requests marked as a dependency upgrade labels Apr 10, 2020
@bdraco bdraco added this to the 0.108.3 milestone Apr 10, 2020
@springstan
Copy link
Copy Markdown
Member

@bdraco I think someone was faster than you 😅 see #33965

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 10, 2020

dupe of #33965

@bdraco bdraco closed this Apr 10, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade integration: homekit small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simultaneous commands from HomeKit is "truncated" HomeKit recent changes: Cannot turn on/off ALL lights at once with Siri?

3 participants