Skip to content

Fix turning off/on light groups in homekit#33965

Merged
balloob merged 1 commit into
home-assistant:devfrom
Knapoc:bump-hap-python-2.8.2
Apr 10, 2020
Merged

Fix turning off/on light groups in homekit#33965
balloob merged 1 commit into
home-assistant:devfrom
Knapoc:bump-hap-python-2.8.2

Conversation

@Knapoc
Copy link
Copy Markdown
Contributor

@Knapoc Knapoc commented Apr 10, 2020

Proposed change

Fix turning off/on light groups in homekit

  • Bump to HAP-python to 2.8.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added dependency Pull requests marked as a dependency upgrade integration: homekit small-pr PRs with less than 30 lines. labels Apr 10, 2020
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@Knapoc please provide a link to the change log.

@Knapoc
Copy link
Copy Markdown
Contributor Author

Knapoc commented Apr 10, 2020

@springstan what kind of change log do you mean? from hap-python? https://github.com/ikalchev/HAP-python/blob/dev/CHANGELOG.md

Btw: just saw that bdraco created a PR for the same changes in #33966.

@springstan
Copy link
Copy Markdown
Member

@Knapoc yes that is exactly what I meant, thanks ✌

Yeah I saw that too, will take care of it.

@bdraco bdraco linked an issue Apr 10, 2020 that may be closed by this pull request
@bdraco bdraco changed the title Bump HAP-python to 2.8.2 Fix turning off/on light groups in homekit Apr 10, 2020
@bdraco bdraco added this to the 0.108.3 milestone Apr 10, 2020
@balloob balloob merged commit 496da88 into home-assistant:dev Apr 10, 2020
@Knapoc Knapoc deleted the bump-hap-python-2.8.2 branch April 10, 2020 18:18
@balloob balloob mentioned this pull request Apr 10, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: homekit small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simultaneous commands from HomeKit is "truncated" HomeKit recent changes: Cannot turn on/off ALL lights at once with Siri?

5 participants