Fix tplink HS220 dimmers (round 2)#33928
Merged
balloob merged 1 commit intohome-assistant:devfrom Apr 10, 2020
Merged
Conversation
* HS220 dimmers are handled as lights with a limited feature set * Dimmers look up has has_emeter every call so this is cached as well now to resovle the performance issue.
probot-home-assistant
Bot
added
has-tests
integration: tplink
small-pr
|
Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration ( |
Member
Author
|
#33909 merged before the device showed up. Had to chance a key and cache the emeter setting. |
Member
Author
|
@rytilahti on the up side, I now have enough of these devices that I can test properly when you get your async version going! |
balloob
pushed a commit
that referenced
this pull request
Apr 10, 2020
* HS220 dimmers are handled as lights with a limited feature set * Dimmers look up has has_emeter every call so this is cached as well now to resovle the performance issue.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
HS220 dimmers are handled as lights with a limited feature set
Dimmers look up has has_emeter every call so this is cached as well now
to resovle the performance issue.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: