Skip to content

Fix tplink HS220 dimmers#33909

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:tplink_hs220_fix
Apr 9, 2020
Merged

Fix tplink HS220 dimmers#33909
balloob merged 1 commit intohome-assistant:devfrom
bdraco:tplink_hs220_fix

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 9, 2020 •
edited
Loading

Proposed change

  • HS220 dimmers are handled as lights with a limited feature set

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco
Fix HS220 dimmers
f493184 
* HS220 dimmers are handled as lights with a limited feature set
@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented Apr 9, 2020

Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration (tplink) you are listed as a codeowner for? Thanks!

@bdraco bdraco added this to the 0.108.2 milestone Apr 9, 2020
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 9, 2020

This is not tested as the device hasn't shown up yet. Will test when it does

@balloob balloob merged commit 6b2baae into home-assistant:dev Apr 9, 2020
@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 9, 2020

Oh only now saw your comment 🙈 When is the device expected to arrive?

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 9, 2020

Oh only now saw your comment 🙈 When is the device expected to arrive?

Just showed up

@bdraco bdraco mentioned this pull request Apr 9, 2020
Merged
20 tasks
balloob pushed a commit that referenced this pull request Apr 10, 2020
@bdraco @balloob
Fix tplink HS220 dimmers (#33909)
e0595ce 
* HS220 dimmers are handled as lights with a limited feature set
@balloob balloob mentioned this pull request Apr 10, 2020
Merged
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

@rytilahti rytilahti

Labels

cherry-picked cla-signed has-tests integration: tplink Testing required

Projects

None yet

Milestone

0.108.2

Development

Successfully merging this pull request may close these issues.

HA 0.108.1 - TP Link Dimmers stopped working

4 participants

@bdraco @balloob @rytilahti @homeassistant