Fix onvif consistent return

[balloob]

Breaking change

Proposed change

Follow-up on #33796

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[Minims]

I still have the issue on my case. I make some debug, and it seems I have an HTTP requests not working :

2020-04-09 11:56:41 DEBUG (MainThread) [homeassistant.components.onvif.camera] Retrieving current camera date/time
2020-04-09 11:56:42 WARNING (MainThread) [homeassistant.components.onvif.camera] Couldn't get camera 'JustIN' date/time. Error: None
2020-04-09 11:56:42 DEBUG (MainThread) [homeassistant.components.onvif.camera] Connecting with ONVIF Camera: 192.168.1.52 on port 5000
2020-04-09 11:56:42 DEBUG (MainThread) [homeassistant.components.onvif.camera] Retrieving profiles
2020-04-09 11:56:44 DEBUG (MainThread) [homeassistant.components.onvif.camera] Retrieved '2' profiles
2020-04-09 11:56:44 DEBUG (MainThread) [homeassistant.components.onvif.camera] Using profile index '0'
2020-04-09 11:56:44 DEBUG (MainThread) [homeassistant.components.onvif.camera] Retrieving stream uri
2020-04-09 11:56:46 DEBUG (MainThread) [homeassistant.components.onvif.camera] ONVIF Camera Using the following URL for JustIN: rtsp://<user>:<password>@192.168.1.52:554/onvif1
2020-04-09 11:56:46 DEBUG (MainThread) [homeassistant.components.onvif.camera] Connecting with ONVIF Camera: 192.168.1.52 on port 5000
2020-04-09 11:56:46 DEBUG (MainThread) [homeassistant.components.onvif.camera] Retrieving profiles
2020-04-09 11:56:49 DEBUG (MainThread) [homeassistant.components.onvif.camera] Retrieved '2' profiles
2020-04-09 11:56:49 DEBUG (MainThread) [homeassistant.components.onvif.camera] Using profile index '0'
2020-04-09 11:56:49 DEBUG (MainThread) [homeassistant.components.onvif.camera] Retrieving snapshot uri
2020-04-09 11:56:51 WARNING (MainThread) [homeassistant.components.onvif.camera] Couldn't connect to camera 'JustIN', but will retry later. Error: None

I goes in ClientConnectionError with err value "None". This error is from the await self.async_obtain_snapshot_uri()

[springstan]

Going to tag this for 0.108.2 as well because it complements #33865 which is already tagged.

[MartinHjelmare]

👍

[MartinHjelmare]

@Minims Two other users reported the fix to solve the connected issue, so it's likely that your issue is a different issue. Please open a new issue with all the info.

[Minims]

@MartinHjelmare Here is my issue, I propose a PR : 95c07b2

[MartinHjelmare]

Please either open a PR with that change or a new issue and link to that commit. I suggest PR since there's already a commit.