Skip to content

Check status code on onvif snapshot#33865

Merged
frenck merged 1 commit intodevfrom
onvif-fix
Apr 9, 2020
Merged

Check status code on onvif snapshot#33865
frenck merged 1 commit intodevfrom
onvif-fix

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 9, 2020

Breaking change

Proposed change

Check the status code to make sure the snapshot url works.

Fixes #33796

I don't have an ONVIF camera so unable to test this. @frenck would you be able to test this?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@frenck frenck merged commit 1adb45f into dev Apr 9, 2020
@frenck frenck deleted the onvif-fix branch April 9, 2020 07:54
response = requests.get(self._snapshot, timeout=5, auth=auth)
return response.content
if response.status_code < 300:
return response.content
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fetch function has inconsistent return values. We should return None explicitly in the two other exits of this function.

@springstan springstan mentioned this pull request Apr 9, 2020
20 tasks
balloob added a commit that referenced this pull request Apr 10, 2020
@balloob balloob mentioned this pull request Apr 10, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ONVIF Camera integration broken in my case

4 participants