Skip to content

Move title translation to root#33850

Merged
balloob merged 1 commit intodevfrom
translations-move
Apr 15, 2020
Merged

Move title translation to root#33850
balloob merged 1 commit intodevfrom
translations-move

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 8, 2020

Breaking change

Proposed change

Because the title translation is stored under the "config" key in the translations, the frontend currently has no choice but to load all translations of all integrations that are loaded + that have a config flow. This is a lot !

This is the first step in cleaning this up: moving title out. Now the frontend can just load the titles (which will come in a future PR).

This PR should not be merged until I have my rename script ready to run to rename all the keys in Lokalise. Done

Part of ADR-0009 proposed in home-assistant/architecture#363

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob force-pushed the translations-move branch from 594cce1 to bb12fc1 Compare April 15, 2020 16:16
@balloob balloob merged commit d36204a into dev Apr 15, 2020
@balloob balloob deleted the translations-move branch April 15, 2020 16:41
@bdraco bdraco mentioned this pull request Apr 16, 2020
20 tasks
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants