Skip to content

Fix minor async issues in Plex#33785

Merged
balloob merged 2 commits intohome-assistant:devfrom
jjlawren:plex_0.108_cleanup
Apr 7, 2020
Merged

Fix minor async issues in Plex#33785
balloob merged 2 commits intohome-assistant:devfrom
jjlawren:plex_0.108_cleanup

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Apr 7, 2020

Proposed change

Was calling the wrong context when sending dispatch events. Shouldn't be dangerous, but good to get correct.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@jjlawren jjlawren added this to the 0.108.0 milestone Apr 7, 2020
Comment thread homeassistant/components/plex/server.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit 3873b23 into home-assistant:dev Apr 7, 2020
balloob pushed a commit that referenced this pull request Apr 7, 2020
* Fix minor async context issues

* Annotate callback
@jjlawren jjlawren deleted the plex_0.108_cleanup branch April 8, 2020 17:28
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants