Skip parsing Plex session if incomplete#33534
Merged
balloob merged 4 commits intohome-assistant:devfrom Apr 6, 2020
Merged
Conversation
probot-home-assistant
Bot
added
integration: plex
small-pr
balloob
reviewed
Apr 2, 2020
Contributor
Author
|
Please hold off on merging, I'd like to dig into the problem a bit more first. |
20 tasks
Contributor
Author
|
I think the underlying problem is a race condition when updates happen too frequently that's now addressed in #33560. Closing this for now. |
Contributor
Author
|
Looks like this might still be necessary after all. Sometimes the data we receive from the Plex API actually isn't complete. |
balloob
reviewed
Apr 5, 2020
balloob
reviewed
Apr 6, 2020
balloob
approved these changes
Apr 6, 2020
balloob
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Skip parsing session if incomplete * Schedule an update if session data is incomplete * Mark as callback * Remove update() & convert to async, abort if any session is incomplete
20 tasks
| @property | ||
| def device_state_attributes(self): | ||
| """Return the state attributes.""" | ||
| return {content[0]: content[1] for content in self._now_playing} |
Member
There was a problem hiding this comment.
We normally want to set the state attribute keys explicitly to be able to check formatting and content.
Contributor
Author
There was a problem hiding this comment.
This was legacy code copied over as-is. It's worked for a long time, I'd rather not touch it right now.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Sometimes incomplete data is returned for an actively playing session. Not much we can do besides skip it and try again later.
In this case the session details will be unavailable, but the session will still be counted in the total number of known sessions.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: