Skip to content

Remove unused manifest fields v2#33656

Merged
frenck merged 1 commit intohome-assistant:devfrom
springstan:unused-manifest-fields
Apr 4, 2020
Merged

Remove unused manifest fields v2#33656
frenck merged 1 commit intohome-assistant:devfrom
springstan:unused-manifest-fields

Conversation

@springstan
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Removes unnecessary and unused manifest fields. This is a followup to #33595.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added the dependency Pull requests marked as a dependency upgrade label Apr 4, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@frenck frenck merged commit 541e30d into home-assistant:dev Apr 4, 2020
@springstan springstan deleted the unused-manifest-fields branch April 4, 2020 20:14
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants