Skip to content

Remove unused manifest fields#33595

Merged
balloob merged 1 commit intodevfrom
remove-unused-manifest-fields
Apr 3, 2020
Merged

Remove unused manifest fields#33595
balloob merged 1 commit intodevfrom
remove-unused-manifest-fields

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 3, 2020

Breaking change

Proposed change

The fields dependencies and requirements are optional manifest fields. They got initially added to all manifests when we introduced manifests. This PR removes them so that we don't unnecessarily create empty lists in memory.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added the dependency Pull requests marked as a dependency upgrade label Apr 3, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hassfest changes look good. I've honestly nog checked every single .json file, but did check a lot and look good 👍

@balloob balloob merged commit f1d3c0d into dev Apr 3, 2020
@balloob balloob deleted the remove-unused-manifest-fields branch April 3, 2020 19:58
@springstan springstan mentioned this pull request Apr 4, 2020
20 tasks
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants