Skip to content

Update pymelcloud to fix broken area device search#33620

Merged
Danielhiversen merged 1 commit intohome-assistant:devfrom
vilppuvuorinen:melcloud-fix-area-device-collect
Apr 4, 2020
Merged

Update pymelcloud to fix broken area device search#33620
Danielhiversen merged 1 commit intohome-assistant:devfrom
vilppuvuorinen:melcloud-fix-area-device-collect

Conversation

@vilppuvuorinen
Copy link
Copy Markdown
Contributor

@vilppuvuorinen vilppuvuorinen commented Apr 4, 2020

Proposed change

Update pymelcloud to find devices assigned to areas in MELCloud.
https://github.com/vilppuvuorinen/pymelcloud/commits/master

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Devices assigned to areas in MELCloud were not available through the
integration due to client lib bug.
@probot-home-assistant probot-home-assistant Bot added integration: melcloud small-pr PRs with less than 30 lines. dependency Pull requests marked as a dependency upgrade by-code-owner labels Apr 4, 2020
Copy link
Copy Markdown
Member

@Danielhiversen Danielhiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Please add a link to the changelog next time. (I have done it now)

@Danielhiversen Danielhiversen merged commit 4a9f4f5 into home-assistant:dev Apr 4, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: melcloud small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants