Conversation
probot-home-assistant
Bot
added
core
has-tests
integration: cloud
small-pr
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
MartinHjelmare
approved these changes
Apr 1, 2020
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! Just a comment on test robustness.
| # Fake connection/discovery | ||
| org_cloud = hass.data["cloud"] | ||
| await org_cloud.iot._on_connect[-1]() | ||
| await hass.helpers.discovery.async_load_platform( |
Member
There was a problem hiding this comment.
It would be nicer if we didn't have to mock integration code directly but could mock things in the periphery instead to have the platform load.
Member
Author
There was a problem hiding this comment.
I agree, our cloud mocks have not kept up over time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Home Assistant Cloud now loads domain info during
async_setup, so when you depend on cloud, you can rely on the fact that we know the remote url.Cloud integration loads now in 1.2s on my mac.
Requires NabuCasa/hass-nabucasa#140 to be released as 0.33.
CC @frenck @cgtobi
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: