Improve start#140
Merged
Merged
Conversation
20 tasks
MartinHjelmare
approved these changes
Apr 1, 2020
Collaborator
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
I'm not familiar with all the details of all the parts of this library. But I think I understand the geist of the change and the change itself looks good.
Collaborator
|
Side question: Can we bump the minimum version of Python to 3.7 for this library? Then we could clean up some asyncio loop handling. |
Member
Author
|
Yeah, we could. Feel free to pick it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make it so that we can call
cloud.start()duringasync_setupand load all critical info during startup.