Skip to content

Fix invalid directory for dnsmasq files in asuswrt#33503

Merged
balloob merged 1 commit intohome-assistant:devfrom
springstan:fix-dnsmasq-path-asuswrt
Apr 1, 2020
Merged

Fix invalid directory for dnsmasq files in asuswrt#33503
balloob merged 1 commit intohome-assistant:devfrom
springstan:fix-dnsmasq-path-asuswrt

Conversation

@springstan
Copy link
Copy Markdown
Member

@springstan springstan commented Apr 1, 2020

Breaking change

Proposed change

Incorrect config validation helper was used to verify the existence of the directory for dnsmasq files. However, this helper cannot be used since it is restricted to local files/directories. This is not the case here because the dnsmasq files are stored on the router.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml entry
asuswrt:
  host: YOUR_ROUTER_IP
  username: YOUR_ADMIN_USERNAME
  ssh_key: /config/id_rsa
  interface: 'eth0'
  dnsmasq: '/var/lib/misc'
  sensors:
    - upload
    - download
    - upload_speed
    - download_speed

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @kennedyshead, mind taking a look at this pull request as its been labeled with a integration (asuswrt) you are listed as a codeowner for? Thanks!

@springstan
Copy link
Copy Markdown
Member Author

Since I was the one who suggested this change here I feel obligated to fix this 😄

@balloob balloob merged commit 0cf9268 into home-assistant:dev Apr 1, 2020
@ollo69
Copy link
Copy Markdown
Contributor

ollo69 commented Apr 2, 2020

What is the meaning of this change? I create a PR for AsusWRT component and now the validation check fail on this test.

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 2, 2020

@ollo69 If there is an issue, please open up an issue (you can refer to other PRs in the issue report).

@ollo69
Copy link
Copy Markdown
Contributor

ollo69 commented Apr 2, 2020

Sorry, my mistake.

@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
@springstan springstan deleted the fix-dnsmasq-path-asuswrt branch April 7, 2020 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid config for [asuswrt]: not a directory for dictionary value @ data[‘asuswrt’][‘dnsmasq’]. Got None.

5 participants