Add asuswrt interface and dnsmasq location configuration by pkishino · Pull Request #29834 · home-assistant/core

pkishino · 2019-12-11T06:44:02Z

Description:

This adds two new parameters to asuswrt configuration to specify dnsmasq location and interface to use for statistics.
This fixes the issue with padavan n56u-project sensors not reading statistics as well as having to create a soft link to dnsmasq file.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11426

Example entry for `configuration.yaml` (if applicable):

# Example configuration.yaml entry
asuswrt:
  host: YOUR_ROUTER_IP
  username: YOUR_ADMIN_USERNAME
  ssh_key: /config/id_rsa
  interface: 'eth0'
  dnsmasq: '/var/lib/misc'
  sensors:
    - upload
    - download
    - upload_speed
    - download_speed

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

probot-home-assistant · 2019-12-11T06:44:08Z

Hey there @kennedyshead, mind taking a look at this pull request as its been labeled with a integration (asuswrt) you are listed as a codeowner for? Thanks!

pkishino · 2020-02-03T09:29:42Z

aioasuswrt has been updated to 1.2.1 to include this update

pkishino · 2020-02-03T11:09:36Z

not sure why it isn't finding the 1.2.1 release:
https://pypi.org/project/aioasuswrt/1.2.1/

kennedyshead · 2020-02-03T11:56:57Z

not sure why it isn't finding the 1.2.1 release:
https://pypi.org/project/aioasuswrt/1.2.1/

That is strange ?!

springstan · 2020-02-03T22:08:28Z

not sure why it isn't finding the 1.2.1 release:
https://pypi.org/project/aioasuswrt/1.2.1/

That is strange ?!

@kennedyshead I can confirm that downloading aioasuswrt==1.2.1 fails locally as well.

kennedyshead · 2020-02-04T07:05:34Z

1.2.2 works, I just installed it locally... Have no idea why 1.2.0 and 1.2.1 fails

springstan · 2020-02-06T22:44:58Z

Please add a test to reach the code coverage difference for this patch :)

pkishino · 2020-02-07T07:48:18Z

Please add a test to reach the code coverage difference for this patch :)

Yeah..trying to fix this but it is complaining about a Lint issue..I have fixed it and locally Lint passes fine, but when I push it to CI it fails...not sure how to fix this

springstan · 2020-02-07T20:03:25Z

@pkishino I am not quite sure but has the codecoverage increased by adding this new test? It looks good but I think you will need to add another test that covers the interface as well.

pkishino · 2020-02-08T10:53:49Z

@pkishino I am not quite sure but has the codecoverage increased by adding this new test? It looks good but I think you will need to add another test that covers the interface as well.

Hey,
not quite sure how to bump the coverage up to pass..tried looking at other test cases and such..
@kennedyshead suggestions?

kennedyshead · 2020-02-08T11:52:28Z

@pkishino I'll have a look see

kennedyshead · 2020-02-10T11:21:29Z

If you bump the tests for sensor.py I think you are done ;)

pkishino · 2020-02-10T23:01:25Z

@kennedyshead yeah, can take a look at that but as there currently are 0 tests for sensor not sure where to start and exactly what needs to be covered there..

codecov · 2020-02-21T04:02:13Z

Codecov Report

Merging #29834 into dev will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #29834      +/-   ##
==========================================
+ Coverage   94.62%   94.73%   +0.11%     
==========================================
  Files         749      766      +17     
  Lines       54193    55568    +1375     
==========================================
+ Hits        51279    52644    +1365     
- Misses       2914     2924      +10

Impacted Files	Coverage Δ
homeassistant/components/demo/config_flow.py	`62.85% <0.00%> (-37.15%)`	⬇️
homeassistant/__init__.py	`89.02% <0.00%> (-6.81%)`	⬇️
homeassistant/components/google_assistant/http.py	`79.16% <0.00%> (-6.67%)`	⬇️
homeassistant/components/light/device_action.py	`93.93% <0.00%> (-6.07%)`	⬇️
homeassistant/components/hue/bridge.py	`72.07% <0.00%> (-3.42%)`	⬇️
homeassistant/components/zha/cover.py	`93.93% <0.00%> (-2.03%)`	⬇️
homeassistant/util/logging.py	`95.83% <0.00%> (-1.61%)`	⬇️
...omponents/homematicip_cloud/alarm_control_panel.py	`98.52% <0.00%> (-1.48%)`	⬇️
homeassistant/components/samsungtv/config_flow.py	`98.24% <0.00%> (-0.75%)`	⬇️
homeassistant/components/uk_transport/sensor.py	`93.47% <0.00%> (-0.73%)`	⬇️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb266d2...50e5e3c. Read the comment docs.

pkishino · 2020-02-21T12:44:45Z

oh come on...this is nonsense...

springstan · 2020-02-21T13:05:18Z

Please remove the following line which omits the specified file from code coverage testing:
https://github.com/home-assistant/home-assistant/blob/dd8597cb46c5e788995e1ea56b87dfbaf43ca51c/.coveragerc#L61

springstan · 2020-02-21T13:48:29Z

@pkishino no worries such a small difference is okay 😉

@kennedyshead please take a look again to approve this PR if everything is fine :)

kennedyshead · 2020-02-21T14:24:18Z

Looks fine to me :)

Added interface and dnsmasq location configuration

f104428

homeassistant added the cla-signed label Dec 11, 2019

probot-home-assistant Bot added integration: asuswrt small-pr PRs with less than 30 lines. labels Dec 11, 2019

pkishino mentioned this pull request Dec 11, 2019

Updated asuswrt.markdown for new update home-assistant/home-assistant.io#11426

Merged

2 tasks

MartinHjelmare changed the title ~~Added interface and dnsmasq location configuration~~ Add asuswrt interface and dnsmasq location configuration Jan 7, 2020

Updated aioasuswrt requirement to latest 1.2.1 release

eb266d2

pkishino marked this pull request as ready for review February 3, 2020 09:29

Rebased

72a13b9

springstan reviewed Feb 3, 2020

View reviewed changes

Comment thread homeassistant/components/asuswrt/__init__.py Outdated

springstan added the dependency Pull requests marked as a dependency upgrade label Feb 3, 2020

pkishino force-pushed the asusfix branch from 0bd55bb to afed924 Compare February 4, 2020 09:12

springstan reviewed Feb 4, 2020

View reviewed changes

Comment thread homeassistant/components/asuswrt/__init__.py Outdated

springstan reviewed Feb 4, 2020

View reviewed changes

Comment thread homeassistant/components/asuswrt/__init__.py Outdated

pkishino force-pushed the asusfix branch from afed924 to d2c7609 Compare February 4, 2020 10:48

pkishino requested a review from a team as a code owner February 4, 2020 10:48

pkishino force-pushed the asusfix branch 3 times, most recently from cc13b6b to e2d3bed Compare February 4, 2020 11:33

springstan reviewed Feb 6, 2020

View reviewed changes

Comment thread homeassistant/components/asuswrt/__init__.py Outdated

pkishino force-pushed the asusfix branch 3 times, most recently from d885af5 to 658bf0c Compare February 7, 2020 06:26

pkishino force-pushed the asusfix branch 4 times, most recently from 40fd429 to 835532b Compare February 7, 2020 07:36

kennedyshead reviewed Feb 7, 2020

View reviewed changes

Comment thread tests/components/asuswrt/test_device_tracker.py Outdated

pkishino force-pushed the asusfix branch from 835532b to 8d3de6f Compare February 7, 2020 10:22

springstan removed the request for review from a team February 7, 2020 20:02

pkishino force-pushed the asusfix branch 2 times, most recently from 8328ec5 to 21db624 Compare February 8, 2020 08:07

pkishino force-pushed the asusfix branch from e4c1173 to 50e5e3c Compare February 21, 2020 04:12

pkishino requested a review from springstan February 21, 2020 04:47

springstan reviewed Feb 21, 2020

View reviewed changes

Comment thread tests/components/asuswrt/test_device_tracker.py Outdated

Comment thread tests/components/asuswrt/test_sensor.py Outdated

pkishino force-pushed the asusfix branch from 50e5e3c to 6fd3a1c Compare February 21, 2020 10:56

Updated to working aioasus library and fixed correct conf formatting

92377d1

pkishino force-pushed the asusfix branch from 6fd3a1c to 92377d1 Compare February 21, 2020 13:12

springstan approved these changes Feb 21, 2020

View reviewed changes

springstan merged commit f32411e into home-assistant:dev Feb 21, 2020

lock Bot locked and limited conversation to collaborators Feb 22, 2020

pkishino deleted the asusfix branch February 28, 2020 12:46

Uh oh!

Conversation

pkishino commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

probot-home-assistant Bot commented Dec 11, 2019

Uh oh!

pkishino commented Feb 3, 2020

Uh oh!

pkishino commented Feb 3, 2020

Uh oh!

kennedyshead commented Feb 3, 2020

Uh oh!

Uh oh!

springstan commented Feb 3, 2020

Uh oh!

kennedyshead commented Feb 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

springstan commented Feb 6, 2020

Uh oh!

pkishino commented Feb 7, 2020

Uh oh!

Uh oh!

springstan commented Feb 7, 2020

Uh oh!

pkishino commented Feb 8, 2020

Uh oh!

kennedyshead commented Feb 8, 2020

Uh oh!

kennedyshead commented Feb 10, 2020

Uh oh!

pkishino commented Feb 10, 2020

Uh oh!

codecov Bot commented Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

pkishino commented Feb 21, 2020

Uh oh!

springstan commented Feb 21, 2020

Uh oh!

springstan commented Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennedyshead commented Feb 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pkishino commented Dec 11, 2019 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

codecov Bot commented Feb 21, 2020 •

edited

Loading

springstan commented Feb 21, 2020 •

edited

Loading