Skip to content

Add config flow for nut#33457

Merged
balloob merged 10 commits intohome-assistant:devfrom
bdraco:nut_config_flow
Apr 1, 2020
Merged

Add config flow for nut#33457
balloob merged 10 commits intohome-assistant:devfrom
bdraco:nut_config_flow

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 31, 2020

Breaking change

The following sensors are no longer supported:

  • ups.time
  • ups.date
  • ups.model
  • ups.mfr
  • ups.mfr.date
  • ups.serial
  • ups.vendorid
  • ups.productid
  • ups.firmware
  • ups.firmware.aux

Proposed change

Add config flow for nut

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/nut/__init__.py Outdated
Comment thread homeassistant/components/nut/__init__.py Outdated
Comment thread homeassistant/components/nut/__init__.py Outdated
Comment thread homeassistant/components/nut/config_flow.py
Comment thread homeassistant/components/nut/config_flow.py
Comment thread homeassistant/components/nut/const.py Outdated
Comment thread homeassistant/components/nut/const.py Outdated
Comment thread homeassistant/components/nut/sensor.py Outdated
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 31, 2020

Well I was testing with the sensors we just removed :) fixing

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 1, 2020

_______ TestTTS.test_setup_component_and_test_service_with_receive_voice _______
flapping again

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 1, 2020

will rebase and rerun ci

@bdraco bdraco force-pushed the nut_config_flow branch from 5979733 to 5291e9e Compare April 1, 2020 00:27
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 1, 2020

Retested, all looks good

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 1, 2020

@MartinHjelmare @balloob TTS tests are flapping again and passing locally. Ok to merge?

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 1, 2020

Yes. I'll need to look into those tests.

@balloob balloob merged commit cc443ff into home-assistant:dev Apr 1, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants