Skip to content

Prevent nut from doing I/O in the event loop#33420

Merged
bdraco merged 2 commits intohome-assistant:devfrom
bdraco:nut_does_io_in_event_loop
Mar 30, 2020
Merged

Prevent nut from doing I/O in the event loop#33420
bdraco merged 2 commits intohome-assistant:devfrom
bdraco:nut_does_io_in_event_loop

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 30, 2020

Proposed change

device_state_attributes would call for an update if the
throttle happened to expire.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

device_state_attributes would call for an update if the
throttle happened to expire.
Comment thread homeassistant/components/nut/sensor.py
@bdraco bdraco merged commit d59209f into home-assistant:dev Mar 30, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed integration: nut small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating state for sensor.nut_ups_input_voltage is taking long than expected

4 participants