Skip to content

Fix minor bmp280 issues mentioned in late review #33211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 2 commits into from
Mar 24, 2020
Merged

Fix minor bmp280 issues mentioned in late review #33211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4002da6
Fix minor issues mentioned in #30837 after it was closed
belidzs Mar 24, 2020
95567d3
Update homeassistant/components/bmp280/sensor.py
belidzs Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions homeassistant/components/bmp280/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
_LOGGER = logging.getLogger(__name__)

DEFAULT_NAME = "BMP280"
DEFAULT_SCAN_INTERVAL = timedelta(seconds=15)
SCAN_INTERVAL = timedelta(seconds=15)

MIN_TIME_BETWEEN_UPDATES = timedelta(seconds=3)

Expand Down Expand Up @@ -51,13 +51,14 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
# this usually happens when the board is I2C capable, but the device can't be found at the configured address
if str(error.args[0]).startswith("No I2C device at address"):
_LOGGER.error(
"%s. Hint: Check wiring and make sure that the SDO pin is tied to either ground (0x76) or VCC (0x77)!",
"%s. Hint: Check wiring and make sure that the SDO pin is tied to either ground (0x76) or VCC (0x77)",
error.args[0],
)
raise PlatformNotReady()
raise error
_LOGGER.error(error.args[0])
Comment thread
belidzs marked this conversation as resolved.
Outdated
return
# use custom name if there's any
name = config.get(CONF_NAME)
name = config[CONF_NAME]
# BMP280 has both temperature and pressure sensing capability
add_entities(
[Bmp280TemperatureSensor(bmp280, name), Bmp280PressureSensor(bmp280, name)]
Expand Down