Skip to content

Fix minor bmp280 issues mentioned in late review#33211

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
belidzs:bmp280
Mar 24, 2020
Merged

Fix minor bmp280 issues mentioned in late review#33211
MartinHjelmare merged 2 commits into
home-assistant:devfrom
belidzs:bmp280

Conversation

@belidzs
Copy link
Copy Markdown
Contributor

@belidzs belidzs commented Mar 24, 2020

Proposed change

Fixed some minor issues which were kindly pointed out by @MartinHjelmare at #30837 (review)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare MartinHjelmare changed the title Fix minor issues mentioned in #30837 after it was closed Fix minor bmp280 issues mentioned in late review Mar 24, 2020
Comment thread homeassistant/components/bmp280/sensor.py Outdated
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 3f4a7ec into home-assistant:dev Mar 24, 2020
@belidzs belidzs deleted the bmp280 branch March 24, 2020 20:54
@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants