Skip to content

Add entities for ZHA groups containing switches#33207

Merged
Adminiuga merged 1 commit into
home-assistant:devfrom
dmulcahey:dm/zha-switch-group-support
Mar 25, 2020
Merged

Add entities for ZHA groups containing switches#33207
Adminiuga merged 1 commit into
home-assistant:devfrom
dmulcahey:dm/zha-switch-group-support

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

Proposed change

This is PR number 2 in the series of PR's to add entity support for ZHA Zigbee groups. This PR adds entities for groups containing 2 or more devices that each have switch entities. This PR will need a rebase after PR ##33196 is merged.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@dmulcahey dmulcahey requested a review from Adminiuga March 24, 2020 12:42
@dmulcahey dmulcahey force-pushed the dm/zha-switch-group-support branch 3 times, most recently from b5519eb to 9720046 Compare March 25, 2020 11:37
@dmulcahey dmulcahey marked this pull request as ready for review March 25, 2020 12:00
@dmulcahey dmulcahey force-pushed the dm/zha-switch-group-support branch 4 times, most recently from 41860d3 to c708348 Compare March 25, 2020 16:13
@dmulcahey dmulcahey force-pushed the dm/zha-switch-group-support branch from c708348 to e8bafc6 Compare March 25, 2020 16:21
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adminiuga Adminiuga merged commit eb8e8d0 into home-assistant:dev Mar 25, 2020
@dmulcahey dmulcahey deleted the dm/zha-switch-group-support branch March 26, 2020 11:17
@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants