Skip to content

Add group entity support to ZHA#33196

Merged
dmulcahey merged 46 commits into
home-assistant:devfrom
dmulcahey:dm/zha-group-entities-take-2
Mar 25, 2020
Merged

Add group entity support to ZHA#33196
dmulcahey merged 46 commits into
home-assistant:devfrom
dmulcahey:dm/zha-group-entities-take-2

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

Proposed change

This PR adds entities for ZHA groups. Starting with this PR if a ZHA Zigbee group contains 2 or members with entities of the same type (in this case lights) we will create an entity to represent the group. This allows us to abstract away all of the work that a user currently has to do in an automation to interact with groups and also provides a single point of contact on the UI (think light group entities) that will allow them to naturally interact with groups of devices. I am planning to follow up this PR with several others to expand the support. Fan, Cover, and Switch will get support next followed by a feature that will give users the ability to override the default chosen entity domain for the group in the ZHA config panel.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

Comment thread homeassistant/components/zha/core/discovery.py Outdated
@dmulcahey dmulcahey force-pushed the dm/zha-group-entities-take-2 branch from 45c51f0 to 01d1c06 Compare March 25, 2020 01:23
@dmulcahey dmulcahey merged commit 2a3c94b into home-assistant:dev Mar 25, 2020
@dmulcahey dmulcahey deleted the dm/zha-group-entities-take-2 branch March 26, 2020 11:17
@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants