Add group entity support to ZHA#33196
Merged
dmulcahey merged 46 commits intoMar 25, 2020
Merged
Conversation
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
20 tasks
Adminiuga
approved these changes
Mar 24, 2020
45c51f0 to
01d1c06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds entities for ZHA groups. Starting with this PR if a ZHA Zigbee group contains 2 or members with entities of the same type (in this case lights) we will create an entity to represent the group. This allows us to abstract away all of the work that a user currently has to do in an automation to interact with groups and also provides a single point of contact on the UI (think light group entities) that will allow them to naturally interact with groups of devices. I am planning to follow up this PR with several others to expand the support. Fan, Cover, and Switch will get support next followed by a feature that will give users the ability to override the default chosen entity domain for the group in the ZHA config panel.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: