Skip to content

General code cleanups for lutron_caseta component#33144

Merged
MartinHjelmare merged 3 commits into
home-assistant:devfrom
swails:cleanup-caseta
Mar 22, 2020
Merged

General code cleanups for lutron_caseta component#33144
MartinHjelmare merged 3 commits into
home-assistant:devfrom
swails:cleanup-caseta

Conversation

@swails
Copy link
Copy Markdown
Contributor

@swails swails commented Mar 22, 2020

Breaking change

The Device ID and Zone ID attributes of Lutron Caseta devices have been renamed to device_id and zone_id to match the convention of the rest of Home Assistant. If you have any automations that reference these attributes, they will need to be updated.

Proposed change

These are small code cleanups pulled into a separate PR for existing platforms requested in #33032

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml - no change from previous versions
lutron_caseta:
  host: 192.168.1.15
  keyfile: caseta.key
  certfile: caseta.crt
  ca_certs: caseta-bridge.crt

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@swails
Copy link
Copy Markdown
Contributor Author

swails commented Mar 22, 2020

@MartinHjelmare, here are the requested changes from #33032 PR applied to the other platforms.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one change needed.

Comment thread homeassistant/components/lutron_caseta/__init__.py Outdated
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@MartinHjelmare MartinHjelmare merged commit 2a3d688 into home-assistant:dev Mar 22, 2020
@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants