Skip to content

Add support for occupancy/vacancy groups in Lutron Caseta component#33032

Merged
MartinHjelmare merged 14 commits into
home-assistant:devfrom
swails:feature/lutron-caseta-occupancy-group-support
Mar 23, 2020
Merged

Add support for occupancy/vacancy groups in Lutron Caseta component#33032
MartinHjelmare merged 14 commits into
home-assistant:devfrom
swails:feature/lutron-caseta-occupancy-group-support

Conversation

@swails
Copy link
Copy Markdown
Contributor

@swails swails commented Mar 20, 2020

Proposed change

This adds support for occupancy groups (Lutron Caseta's version of motion sensors) for which support was recently added to Lutron Caseta system.

This follows updates to pylutron-caseta to add support for these
devices. This code works for me as a custom component in Home Assistant
Core with pylutron-caseta 0.6.0 (currently unreleased).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml - no change from previous versions
lutron_caseta:
  host: 192.168.1.15
  keyfile: caseta.key
  certfile: caseta.crt
  ca_certs: caseta-bridge.crt

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 20, 2020

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️

Please, add your GitHub username to the manifest.json of this integration.

For more information about "code owners", see: Architecture Decision Record 0008: Code owners.

Comment thread homeassistant/components/lutron_caseta/__init__.py Outdated
Comment thread homeassistant/components/lutron_caseta/binary_sensor.py Outdated
Comment thread homeassistant/components/lutron_caseta/binary_sensor.py Outdated
Comment thread homeassistant/components/lutron_caseta/binary_sensor.py Outdated
Comment thread homeassistant/components/lutron_caseta/binary_sensor.py Outdated
Comment thread homeassistant/components/lutron_caseta/binary_sensor.py Outdated
@swails
Copy link
Copy Markdown
Contributor Author

swails commented Mar 21, 2020

I rebased against the upstream dev branch.

Comment thread homeassistant/components/lutron_caseta/__init__.py Outdated
@swails
Copy link
Copy Markdown
Contributor Author

swails commented Mar 21, 2020

The remaining test failure is a result of a new release not being cut yet for pylutron-caseta. I have an issue opened to have that release cut ASAP: gurumitts/pylutron-caseta#43

@MartinHjelmare MartinHjelmare added breaking-change waiting-for-upstream We're waiting for a change upstream labels Mar 21, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

Please ping me here when we're ready to continue.

@swails swails force-pushed the feature/lutron-caseta-occupancy-group-support branch from 9fd9fa0 to d670353 Compare March 22, 2020 22:53
@swails
Copy link
Copy Markdown
Contributor Author

swails commented Mar 22, 2020

@MartinHjelmare - this is ready to proceed. I removed the breaking changes section of the PR, since those were done in #33144 and no further breaking changes were made here.

The upstream project has published a new release, so we should be ready to move forward.

@MartinHjelmare MartinHjelmare removed breaking-change waiting-for-upstream We're waiting for a change upstream labels Mar 23, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@MartinHjelmare MartinHjelmare merged commit 49ebea2 into home-assistant:dev Mar 23, 2020
@swails swails deleted the feature/lutron-caseta-occupancy-group-support branch March 23, 2020 13:32
@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants