Support melcloud swing mode#33008
Conversation
|
Hey there @vilppuvuorinen, mind taking a look at this pull request as its been labeled with a integration ( |
|
I tried to intentionally avoid implementing this feature. Here we have a device with 2 sets of vanes which can be set to n static positons, automatic mode that does something smart and swing mode. It does swing, but it's missing 42 vane combinations and only one of the avaible 7 does swing. I was hoping for an extension for the |
|
I understand that it will not be optimal for your device, but I still think it is worth to add this. For me, it will be a dealbreaker to not have this option, and I would have to continue to use my custom component. |
|
Yeah. I do see the point with this. I'd really hope to get the "proper" vane control #32672 merged before this and have them work the same behind the scenes. |
|
Ohh, I had not seen your PR: You should fix the failing tests. |
|
I'd like to propose an alternative solution for swing modes managing both Vertical and Horizontal modes without the need to manage 42 combination but with the advantage of direct control from UI. |
Co-Authored-By: Vilppu Vuorinen <vilppu.vuorinen@jubic.fi>
Co-Authored-By: Vilppu Vuorinen <vilppu.vuorinen@jubic.fi>
Co-Authored-By: Vilppu Vuorinen <vilppu.vuorinen@jubic.fi>
Co-Authored-By: Vilppu Vuorinen <vilppu.vuorinen@jubic.fi>
Breaking change
melcloud, support for swing mode
Proposed change
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: