Skip to content

Support melcloud swing mode#33008

Merged
Danielhiversen merged 5 commits intodevfrom
melcloud
Apr 4, 2020
Merged

Support melcloud swing mode#33008
Danielhiversen merged 5 commits intodevfrom
melcloud

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Breaking change

melcloud, support for swing mode

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @vilppuvuorinen, mind taking a look at this pull request as its been labeled with a integration (melcloud) you are listed as a codeowner for? Thanks!

@vilppuvuorinen
Copy link
Copy Markdown
Contributor

I tried to intentionally avoid implementing this feature. Here we have a device with 2 sets of vanes which can be set to n static positons, automatic mode that does something smart and swing mode. It does swing, but it's missing 42 vane combinations and only one of the avaible 7 does swing.

I was hoping for an extension for the climate platform, but that's not coming along. Now the only option to get these to the UI is to use tangentially related property to expose part of the functionality.

@Danielhiversen
Copy link
Copy Markdown
Member Author

I understand that it will not be optimal for your device, but I still think it is worth to add this.

For me, it will be a dealbreaker to not have this option, and I would have to continue to use my custom component.

@vilppuvuorinen
Copy link
Copy Markdown
Contributor

Yeah. I do see the point with this. I'd really hope to get the "proper" vane control #32672 merged before this and have them work the same behind the scenes.

@Danielhiversen
Copy link
Copy Markdown
Member Author

Danielhiversen commented Mar 19, 2020

Ohh, I had not seen your PR: You should fix the failing tests.
I think we should have both service and these functions.

@MartinHjelmare MartinHjelmare changed the title melcloud, support for swing mode Support melcloud swing mode Mar 19, 2020
@ollo69
Copy link
Copy Markdown
Contributor

ollo69 commented Apr 3, 2020

I'd like to propose an alternative solution for swing modes managing both Vertical and Horizontal modes without the need to manage 42 combination but with the advantage of direct control from UI.
I understand that the service solution implemented by @vilppuvuorinen theoretically solve this, but unfortunatly many user doesn't know what service are and just want to have a list of swing mode to select.
Obviosly I cannot submit another PR with the sam e subject till this one is open.

Comment thread homeassistant/components/melcloud/climate.py Outdated
Comment thread homeassistant/components/melcloud/climate.py Outdated
Comment thread homeassistant/components/melcloud/climate.py Outdated
Comment thread homeassistant/components/melcloud/climate.py Outdated
Daniel Høyer Iversen and others added 5 commits April 4, 2020 10:20
Co-Authored-By: Vilppu Vuorinen <vilppu.vuorinen@jubic.fi>
Co-Authored-By: Vilppu Vuorinen <vilppu.vuorinen@jubic.fi>
Co-Authored-By: Vilppu Vuorinen <vilppu.vuorinen@jubic.fi>
Co-Authored-By: Vilppu Vuorinen <vilppu.vuorinen@jubic.fi>
@Danielhiversen Danielhiversen merged commit 05192b7 into dev Apr 4, 2020
@delete-merged-branch delete-merged-branch Bot deleted the melcloud branch April 4, 2020 12:07
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants