Add melcloud AtaDevice vane control#32672
Merged
springstan merged 6 commits intohome-assistant:devfrom Apr 2, 2020
Merged
Conversation
Use state attributes and services to provide control for horizontal and vertical vanes.
7 tasks
springstan
reviewed
Mar 13, 2020
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
20 tasks
Member
|
@rudizl Please don't ping random people, that is absolutely not appreciated. |
springstan
reviewed
Mar 27, 2020
springstan
reviewed
Mar 29, 2020
springstan
approved these changes
Mar 29, 2020
Member
springstan
left a comment
springstan
left a comment
There was a problem hiding this comment.
LGTM 👍 thanks for including my suggested changes.
springstan
reviewed
Apr 1, 2020
springstan
reviewed
Apr 1, 2020
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
| ) | ||
|
|
||
| vane_vertical = self._device.vane_vertical | ||
| if vane_horizontal: |
Member
There was a problem hiding this comment.
Is the vertical vane dependent on the horizontal vane?
Contributor
Author
There was a problem hiding this comment.
Aww.. That requires another PR to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use state attributes and services to provide control for horizontal and
vertical vanes.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: