Skip to content

Ensure AirVisual import config flow checks API key correctness#32624

Merged
bachya merged 3 commits intohome-assistant:devfrom
bachya:airvisual-test-fixes
Mar 10, 2020
Merged

Ensure AirVisual import config flow checks API key correctness#32624
bachya merged 3 commits intohome-assistant:devfrom
bachya:airvisual-test-fixes

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Mar 9, 2020

Proposed change

This PR adds ensures that the AirVisual import config flow checks that its API key is correct. Additionally, it adds some small improvements to the AirVisual config flow tests (per @MartinHjelmare's comments).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
airvisual:

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bachya bachya requested a review from MartinHjelmare March 9, 2020 21:10
@bachya bachya self-assigned this Mar 9, 2020
@probot-home-assistant probot-home-assistant Bot added has-tests small-pr PRs with less than 30 lines. labels Mar 9, 2020
@bachya bachya mentioned this pull request Mar 9, 2020
20 tasks
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the config flow too.

@bachya bachya changed the title Add small improvements to AirVisual config flow tests Ensure AirVisual import config flow checks API key correctness Mar 9, 2020
Comment thread homeassistant/components/airvisual/config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bachya bachya merged commit f456189 into home-assistant:dev Mar 10, 2020
@bachya bachya deleted the airvisual-test-fixes branch March 10, 2020 03:39
@lock lock Bot locked and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-tests small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants