Add config entry for AirVisual#32072
Merged
bachya merged 32 commits intohome-assistant:devfrom Feb 29, 2020
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Kane610
reviewed
Feb 22, 2020
Member
Kane610
left a comment
There was a problem hiding this comment.
The PR could be simplified by splitting out the options flow and using default values
7 tasks
bachya
commented
Feb 22, 2020
Kane610
reviewed
Feb 23, 2020
fb700f7 to
f05a4bb
Compare
Contributor
Author
|
@Kane610 Anything else you want to see here? |
Kane610
requested changes
Feb 28, 2020
This reverts commit 5477f89.
3508adb to
d8005fb
Compare
Kane610
approved these changes
Feb 28, 2020
Member
Kane610
left a comment
There was a problem hiding this comment.
Looks good 👍🏻 Just one user step left in tests.
Contributor
Author
|
Thanks, @MartinHjelmare. I’m out of the country for a week; I’ll take care of these notes when I return. |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The config schema for AirVisual has changed; users who configure
AirVisualviaconfiguration.yamlwill need to update. Additionally, in order to protect the AirVisual cloud API,scan_intervalis no longer configurable for this integration.Proposed change
This PR adds a config entry for AirVisual. It does not include config options; that will come in a future PR.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: