Skip to content

Rework Twitch Integration#31632

Closed
timmo001 wants to merge 1 commit into
home-assistant:devfrom
timmo001:twitch
Closed

Rework Twitch Integration#31632
timmo001 wants to merge 1 commit into
home-assistant:devfrom
timmo001:twitch

Conversation

@timmo001
Copy link
Copy Markdown
Member

@timmo001 timmo001 commented Feb 8, 2020

Breaking change

TBD

Proposed change

TBD

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • Link to documentation pull request: TBD

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@timmo001 timmo001 changed the title 🖥Rework Twitch Integration Rework Twitch Integration Feb 8, 2020
@timmo001
Copy link
Copy Markdown
Member Author

timmo001 commented Feb 8, 2020

When you work on something and completely miss the fact that someone is already making a change to the integration once you push... (#31122) Oh well good practice 😄

It would be nice to get this integration into the entity registry though, since adding streamers via the ui is super simple

@timmo001 timmo001 closed this Feb 8, 2020
@TheZoker
Copy link
Copy Markdown
Contributor

TheZoker commented Feb 8, 2020

Would really appreciate a way to add this via UI :) Maybe you can create a follow up PR, that is based on #31122 with config flow?

@lock lock Bot locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants