Add Twitch subscription and additional stats#31122
Merged
Merged
Conversation
Contributor
Author
|
I wrote tests to ensure the integration is working correctly, but I can't get the mocks to work in the correct way. They work if executed one by one but not when executed together. |
7 tasks
springstan
reviewed
Feb 1, 2020
springstan
reviewed
Feb 17, 2020
springstan
approved these changes
Feb 18, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
LGTM ✌ just one small suggestion:
Member
|
You will need to adjust the tests as well I think :) |
Lets be consistent Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
Contributor
Author
|
Done :D |
| def device_state_attributes(self): | ||
| """Return the state attributes.""" | ||
| attr = { | ||
| ATTR_FRIENDLY_NAME: self._channel.display_name, |
Member
There was a problem hiding this comment.
We don't set this state attribute. Setting the name property is enough.
|
I hope it's appropriate to comment here, I wanted to bring to light an issue I have posted that may be relevant to implement during this change. #32050 Thank you. |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This change adds more stats about the specified streamer as well as the opportunity to check follow and subscription status.
There are also tests for all functionalities
Type of change
Example entry for
configuration.yaml:To get the oauth_token take a look to the doc PR.
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: