Skip to content

Fix availability for hue lights and sensors#30915

Closed
springstan wants to merge 1 commit into
home-assistant:devfrom
springstan:fix-hue-key-error
Closed

Fix availability for hue lights and sensors#30915
springstan wants to merge 1 commit into
home-assistant:devfrom
springstan:fix-hue-key-error

Conversation

@springstan
Copy link
Copy Markdown
Member

Description:

Related issue (if applicable): fixes #30876

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

hue:
  bridges:
    - host: 192.168.1.102

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@probot-home-assistant
Copy link
Copy Markdown

Hey there @balloob, mind taking a look at this pull request as its been labeled with a integration (hue) you are listed as a codeowner for? Thanks!

@balloob balloob added this to the 0.104.2 milestone Jan 17, 2020
@springstan
Copy link
Copy Markdown
Member Author

I do not understand why the tests are failing, I compared my changes to other integrations with deprecated configuration variables and they all seem to use this kind of schema.

@springstan
Copy link
Copy Markdown
Member Author

This PR is not sufficient in fixing the mentioned issue, furthermore I cannot test this locally and therefore I will close it.

@springstan springstan closed this Jan 17, 2020
@springstan springstan deleted the fix-hue-key-error branch January 17, 2020 21:23
@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 17, 2020

Thanks for trying to pick it up, I did a fix now in #30924. Heading for 104.2 !

@balloob balloob removed this from the 0.104.2 milestone Jan 17, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed integration: hue small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HUE Lights and sensors not available in Home Assistant 0.104.1

3 participants