Reinstate and deprecate filename option for hue config#30846
Merged
Conversation
probot-home-assistant
Bot
added
has-tests
integration: hue
small-pr
frenck
approved these changes
Jan 16, 2020
delete-merged-branch
Bot
deleted the
reinstate-and-deprecate-filename-hue
branch
balloob
added a commit
that referenced
this pull request
Jan 16, 2020
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In #30000 I removed the
filenameoption because I thought that no one was using it. That was not the case, it was still mentioned in the docs and people thought they had to use it (it hasn't been used by the code since March 2018!).So instead now deprecating it, and marked for removal in 106.
Docs: home-assistant/home-assistant.io#11773
Related issue (if applicable): fixes #30820
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: