Update service domain for lifx from 'light' to 'lifx'

[raman325]

Breaking Change:

This change breaks existing service call references to the light.lifx_* services by changing the service calls to be lifx.*.

Description:

Update the domain and service name for lifx.*. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11310

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

[amelchio]

Sorry to be the grumpy janitor. However, the reason that this change has lingered (at least for LIFX) is that it was supposed to be a slightly larger refactor where service registration is moved to __init__.py, see for example #25753 (comment)

Maybe @balloob changed his mind though, that has happened before ;-)

[pvizeli]

No, we start a long time now to move away from run it on same namespace. I.e. sonos

[amelchio]

That is exactly what I say, this PR does not do it like Sonos.

Same with my linked comment, the Kodi PR first did the simple change of modifying the domain argument but @balloob then argued that the registration should be moved to async_setup in the component.

[MartinHjelmare]

I know Paulus has said that the registration should happen in the component module but I think for most platforms where the action happens in the platform that just brings more complexity without any apparent benefit.

I think it's ok to register the service to the integration domain in the platform.

Is there any reason to avoid it?

[balloob]

Yeah, I've changed my mind. Let's change the domain first, then try to convince developers to move them to __init__.py