Move Kodi services from 'media_player' domain to 'kodi'

[JeffLIrion]

Breaking Change:

The media_player.kodi_* services are now kodi.*.

• media_player.kodi_add_to_playlist is now kodi.add_to_playlist
• media_player.kodi_call_method is now kodi.call_method

Description:

Move the Kodi services to their own domain.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10081

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[ghost]

Hey there @armills, mind taking a look at this pull request as its been labeled with a integration (kodi) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

[JeffLIrion]

@balloob I think DOMAIN and DATA_KODI should be merged into one constant. Right?

[amelchio]

When doing this for sonos (#15089), it was decided that the registration should be in the component, not a platform.

I am not sure whether the rules have changed, maybe @balloob can clarify?

[JeffLIrion]

Are there any additional changes that need to be made?

[balloob]

@amelchio is right. We should register the services in __init__.py inside an async_setup

[JeffLIrion]

@balloob I'm not familiar with the HA setup functions and what should go in __init__.py vs..media_player.py. Any chance we could merge this as is and a subsequent pull request could move the service registration to __init__.py?

[balloob]

We should only merge this PR if we do it right, so that future PRs will build on top of the right foundation.

It should be the exact same code, just be put inside async_setup. https://developers.home-assistant.io/docs/en/creating_component_index.html

[JeffLIrion]

OK, I'll give it a shot.

If we register the services in __init__.py, won't those services show up even if the user only setup the Kodi notify component, not the media player component?

[balloob]

Then we should guard that :)

[JeffLIrion]

Then we should guard that :)

I checked this via:

from homeassistant.components.media_player.const import DOMAIN as MP_DOMAIN


async def async_setup(hass, config):
    """Set up the Kodi integration."""
    if any(
        ((CONF_PLATFORM, DOMAIN) in cfg.items() for cfg in config.get(MP_DOMAIN, []))
    ):
        # Register the Kodi media_player services

I tried it out and it only registers the services if there is a Kodi media player config entry. But if this is not the proper way to do it, let me know.

[balloob]

You can mark it as kodi/*

[balloob]

Great!

[balloob]

Kodi is slowly growing up, soon we might be able to automatically discover it and set it up using a config flow?

[JeffLIrion]

Don't forget about the corresponding documentation pull request!

home-assistant/home-assistant.io#10081