Use roku.poweron method for media_player.turn_on#29123
Merged
Merged
Conversation
Instead of using the roku.power method, which toggles power, implement the media_player.turn_on command for the roku component by calling the new roku.poweron method. Fixes home-assistant#28961, but depends on upstream jcarbaugh/python-roku#53
probot-home-assistant
Bot
added
integration: roku
small-pr
Contributor
|
@bwarden I think that the issue may be the same as #28891 I have two PRs that should take care of the turn_on issues. |
pvizeli
approved these changes
Nov 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
Instead of using the roku.power method, which toggles power, implement the media_player.turn_on command for the roku component by calling the new roku.poweron method.
Fixes #28961, but depends on upstream jcarbaugh/python-roku#53 to be accepted and released.
Related issue (if applicable): fixes #28961
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: