Add STATE_STANDBY to base media_player and fix state reporting issues#28897
Closed
ktnrg45 wants to merge 2 commits into
Closed
Add STATE_STANDBY to base media_player and fix state reporting issues#28897ktnrg45 wants to merge 2 commits into
ktnrg45 wants to merge 2 commits into
Conversation
probot-home-assistant
Bot
added
core
integration: media_player
integration: ps4
small-pr
ktnrg45
changed the title
ktnrg45
changed the title
ktnrg45
changed the title
ktnrg45
changed the title
ktnrg45
changed the title
This was referenced Nov 27, 2019
Member
|
All changes to the entity component need to be proposed in the architecture repo as per the docs: https://developers.home-assistant.io/docs/en/entity_index.html#changing-the-entity-model Going to close this and we can re-open if addition agreed upon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add STATE_STANDBY to base media_player. Roku and PS4 already uses STATE_STANDBY.
Fixes issue for PS4 when the lovelace media_player card calls service turn_off when power button is pressed if state is standby. This PR is complimentary with home-assistant/frontend#4250, although the actual issue fix is dependent on it. Also fixes incorrect state reporting in Homekit and Universal.
Add STATE_STANDBY to base media_player.
Add STATE_STANDBY to Homekit
Add STATE_STANDBY to Universal
Also override base media_player.async_toggle for PS4.
Related issue (if applicable): fixes #28891
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass