Add fan support to lutron_caseta#29033
Merged
MartinHjelmare merged 10 commits intoNov 28, 2019
Merged
Conversation
mdonoughe
reviewed
Nov 26, 2019
MartinHjelmare
requested changes
Nov 26, 2019
Contributor
Author
|
@MartinHjelmare Modifications completed. Note I added an additional mapping for FAN_MEDIUM_HIGH: SPEED_MEDIUM. Found a bug when testing out the changes in this PR. When setting the fan speed the mediumhigh directly on the switch, it would cause an error because I did not map the additional lutron speed. It will seem that we need to revisit the concepts outlined in this architectural issue here as this seems to be a common occurrence for fan components: home-assistant/architecture#127 |
Member
|
@mdonoughe Ok to merge? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
Adding lutron caseta fan component using pylutron_caseta 0.5.1
Changes. Handle None returned from pylutron_caseta. Updates to use built in fan constants from pylutron_caseta.
Note: This is a re-pull of #24770 which could not be merged due to pylutron_caseta being abandoned. The project is up and running and ready to go.
Note: The PR for updating pylutron_caseta is here #28886 and must go hand and hand with this one.
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9780
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: