Add serial to caseta devices#28886
Merged
Merged
Conversation
probot-home-assistant
Bot
added
integration: lutron_caseta
small-pr
MartinHjelmare
changed the title
7 tasks
balloob
reviewed
Nov 26, 2019
balloob
reviewed
Nov 26, 2019
balloob
approved these changes
Nov 26, 2019
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Few small comments, ok to merge when addressed.
mdonoughe
changed the title
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "config": { | |||
| "title": "Lutron Caséta" | |||
Contributor
Author
There was a problem hiding this comment.
This appears in the entity registry.
Member
There was a problem hiding this comment.
Should we now always add this file if the entity registry is active for an integration?
Member
There was a problem hiding this comment.
It looks like that is a new requirement based on the recent changes. I would love for us to be add this translation key at the root instead of config, so we could split out translations into multiple files in the future.
I don't like translation of titles of integrations, but for built-in ones like Lights etc it's useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This adds serial numbers to lutron_caseta devices and enables the entity registry.
This was previously entered as #14037 which could not be merged because pylutron_caseta had not released.
Related issue (if applicable): Incidentally, because this brings in the new release of pylutron_caseta it also partially addresses #22907. It does not add support for fans, but users will no longer lose functionality when a fan controller is introduced.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable): N/AChecklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: