Skip to content

Improve speed websocket sends messages #27295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Oct 8, 2019
+10 −4
Merged

Improve speed websocket sends messages #27295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fab5d5
Improve speed websocket sends messages
balloob Oct 7, 2019
8c58864
return -> continue
balloob Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions homeassistant/components/websocket_api/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,15 @@ async def _writer(self):
message = await self._to_write.get()
if message is None:
break

self._logger.debug("Sending %s", message)

if isinstance(message, str):
await self.wsock.send_str(message)
continue

try:
if isinstance(message, str):
await self.wsock.send_str(message)
else:
await self.wsock.send_json(message, dumps=JSON_DUMP)
dumped = JSON_DUMP(message)
except (ValueError, TypeError) as err:
self._logger.error(
"Unable to serialize to JSON: %s\n%s", err, message
Expand All @@ -76,6 +79,9 @@ async def _writer(self):
message["id"], ERR_UNKNOWN_ERROR, "Invalid JSON in response"
)
)
continue

await self.wsock.send_str(dumped)

@callback
def _send_message(self, message):
Expand Down