Improve speed websocket sends messages#27295
Merged
Merged
Conversation
probot-home-assistant
Bot
added
Hacktoberfest
core
integration: websocket_api
small-pr
balloob
added a commit
that referenced
this pull request
Oct 8, 2019
* Improve speed websocket sends messages * return -> continue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Based on the implementation of
websocket_client.send_jsonwe can just usesend_str, which saves us an await. This makes sending data slightly faster.Related issue (if applicable): zachowj/node-red-contrib-home-assistant-websocket#153
Checklist:
tox. Your PR cannot be merged unless tests pass