Skip to content

Only generate device trigger for sensor with unit#27152

Merged
balloob merged 1 commit into
home-assistant:devfrom
emontnemery:device_trigger_sensor_unit
Oct 3, 2019
Merged

Only generate device trigger for sensor with unit#27152
balloob merged 1 commit into
home-assistant:devfrom
emontnemery:device_trigger_sensor_unit

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Oct 3, 2019 •
edited
Loading

Description:

Only generate device trigger for sensor with unit.
This check is missing from PR #27133 which introduces device triggers for sensors.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@emontnemery emontnemery added this to the 0.100 milestone Oct 3, 2019
@balloob balloob merged commit 89ebc17 into home-assistant:dev Oct 3, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

No one assigned

Labels

cherry-picked cla-signed core Hacktoberfest has-tests integration: sensor

Projects

None yet

Milestone

0.100

Development

Successfully merging this pull request may close these issues.

4 participants

@emontnemery @balloob @frenck @homeassistant