Add device trigger support to sensor entities#27133
Merged
emontnemery merged 3 commits intoOct 3, 2019
Merged
Conversation
balloob
approved these changes
Oct 2, 2019
emontnemery
commented
Oct 2, 2019
Comment on lines
+1131
to
+1135
| def assert_lists_same(a, b): | ||
| """Compare two lists, ignoring order.""" | ||
| assert collections.Counter([hashdict(i) for i in a]) == collections.Counter( | ||
| [hashdict(i) for i in b] | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Added to compare lists with different order since the order of automations is not deterministic when we have automations from different domains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add device trigger support to
sensorentities.This includes trigger part from #26854
This PR is intended as a step towards home-assistant/architecture#178
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: