Fix tahoma reversed closed status for non horizontal awnings

[psicot]

Home Assistant release with the issue:

0.99.2

Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io

Description:

Related issue: fixes #25240
Also fixes the closed status when the position is changed when the position is <= 5 or when the position is >= 95.

The problem appeared in #23257 where the right closed status has been modified for non horizontal awnings (file homeassistant/components/tahoma/cover.py, removed line 117).

Example entry for configuration.yaml

tahoma:
  username: TAHOMA_USERNAME
  password: TAHOMA_PASSWORD

[homeassistant]

Hi @psicot,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[psicot]

@kbickar as the author of #23257, could you please check if the change to the closed status is required for horizontal awnings?
I restored the functioning of the closed state for non-horizontal awnings, but I'd like to make sure that it also works for horizontal awnings. Thanks!

[frenck]

This feels like a never-ending PR/discussion. The PR you mentioned as the source of the issue, has actually been reverted, so your callout makes no sense.

• Tahoma: Do not reverse open/close calls (Tahoma: Do not reverse open/close calls #24879)
• Position is reversed for horizontal awnings (Position is reversed for horizontal awnings #23257)

Related discussions and issues:

• Tahoma HorizontalAwning not working anymore (Tahoma HorizontalAwning not working anymore #24813) (largest discussion)
• Tahoma cover open / closed reversed (Tahoma cover open / closed reversed #24818)
• tahoma service call cover op en closed reversed (tahoma service call cover op en closed reversed #24832)
• Tahoma: Windows and Awnings open/close status reversed (Tahoma: Windows and Awnings open/close status reversed #25240)
• Thahoma Cover percentages reversed (Thahoma Cover percentages reversed #16868)

I feel like we should stop the juggle and add support for a reverse flag or similar.

[psicot]

Thanks @frenck for your reply.

#24879 has not resolved this issue. In 0.99.2 the problem still persists because this PR has not fixed the reversed closed state introduced by #23257, ie:

self._closed = self._position == 100

I think that the HORIZONTAL_AWNING option only need to change the calculation of the position, and must not reverse the closed state of all other accessories (roller shutters and garage door for my case).

[psicot]

Hello, any news concerning this fix?
I run this code has a custom_components since 10 days without issue.
Thanks!

All Tahoma users should be impacting by the change in #23257, which reverses the open/closed states.

[pax2011]

Hello, any news concerning this fix?
I run this code has a custom_components since 10 days without issue.
Thanks!

All Tahoma users should be impacting by the change in #23257, which reverses the open/closed states.

I don't understand how to solve it. I'm on HA 0.94.4, if update i get wrong open/close status.

[psicot]

I don't understand how to solve it. I'm on HA 0.94.4, if update i get wrong open/close status.

@pax2011, fix the reversed statuses is the purpose of this PR (pull request).

To fix this problem, you can wait until this correction is included in a future version of HA.

Another solution is to use my modified code by downloading my version of the tahoma component, and use it has a remplacement of the one embedded in home assistant. You can follow these instructions to install a custom component in your config directory.

My modified Tahoma component is available here.

[pax2011]

I don't understand how to solve it. I'm on HA 0.94.4, if update i get wrong open/close status.

@pax2011, fix the reversed statuses is the purpose of this PR (pull request).

To fix this problem, you can wait until this correction is included in a future version of HA.

Another solution is to use my modified code by downloading my version of the tahoma component, and use it has a remplacement of the one embedded in home assistant. You can follow these instructions to install a custom component in your config directory.

My modified Tahoma component is available here.

I did it! Thanks man. Updated HA, used your code and now is working.

[psicot]

I did it! Thanks man. Updated HA, used your code and now is working.

@pax2011 🎉

[medaemon]

Hello, I have updated to 0.99.3 but I still have the issue on the state of my covers, closed when open open when closed.
Perhaps I miss understand and that the fix is not present in the last HA version, status is not very clear for me (I'm a rookie on the HA fix status ^^).

[DjMoren]

@medaemon, 0.99.3 was released 11 days ago and this PR has been merged 20 hours ago, so no, it's not included in 0.99.3. I don't know the release scheme HA follows (in which release will be included), but meanwhile, you could give a try to it following the instructions given by @psicot.

[balloob]

This will be released on Wednesday.