Tahoma: Do not reverse open/close calls

[balloob]

Breaking Change:

Tahoma: the open/close service functionality works again like in 0.94.

Please test this and let me know if this works.

Description:

In 0.95 (via #23257) the issue of horizontal awning having reverse open/close position was addressed. It also included the switching open/close services, which was incorrect, a reported in #24813.

Related issue (if applicable): fixes #24813

[ghost]

Hey there @philklei, mind taking a look at this pull request as its been labeled with a integration (tahoma) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

[Godtoh]

Please bear in mind there seems to be a distinguish between horizontal awnings and vertical blinds.
For vertical blinds it needs to be as in 0.94, thus:
Open = 0% (windows not covered)
Closed = 100% (windows fully covered)

[balloob]

Nothing was ever changed for vertical awnings. All changes are guarded by a check if it's a horizontal awning. Or are vertical awnings reported as horizontal?

[Godtoh]

This entity comes straight from my Tahoma:
`

cover.erker_achter	closed	current_position: 100 tahoma_device_id: io://1203-2650-7541/4284208 rssi_level: 72 friendly_name: Erker achter supported_features: 15 device_class: awning

`

It is activated as a vertical screen in Tahoma.

[balloob]

We check explicitly for horizontal type.

[Godtoh]

Sorry, no joy, still inverted.

cover.erker_achter	closed	current_position: 100 tahoma_device_id: io://1203-2650-7541/4284208 rssi_level: 64 friendly_name: Erker achter supported_features: 15 device_class: awning

While the cover is open and the position is 0.

Set cover to position is inverted as well, so for me it's no good.

[dennismeng]

@balloob I Upgraded to 0.96, and they are still inverted. Both windows and awnings are inverted in their status.
Yes, the custom_component has been removed prior to reboot of HA :-)

[frenck]

@dennisdegreef Please do not comment on closed/handled merge request, there is no way to track this.
Please open up an issue if you feel like this is one.