Skip to content

HM-CC-TC was not recognized #26623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvizeli merged 2 commits into from
Sep 23, 2019
Merged

HM-CC-TC was not recognized #26623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a83e1
HM-CC-TC was not recognized
MajestyIV Sep 13, 2019
702d082
guard instead of exception
MajestyIV Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions homeassistant/components/homematic/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ def preset_mode(self):
if self._data.get("BOOST_MODE", False):
return "boost"

# Get the name of the mode
if not self._hm_control_mode:
return None
Copy link
Copy Markdown
Member

@pvizeli pvizeli Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, to fire an exception, we should add a guard before.

if not self._hm_control_mode:
    return None


mode = HM_ATTRIBUTE_SUPPORT[HM_CONTROL_MODE][1][self._hm_control_mode]
mode = mode.lower()

Expand Down Expand Up @@ -177,8 +179,9 @@ def _hm_control_mode(self):
"""Return Control mode."""
if HMIP_CONTROL_MODE in self._data:
return self._data[HMIP_CONTROL_MODE]

# Homematic
return self._data["CONTROL_MODE"]
Copy link
Copy Markdown
Member

@pvizeli pvizeli Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return self._data.get("")

return self._data.get("CONTROL_MODE")

def _init_data_struct(self):
"""Generate a data dict (self._data) from the Homematic metadata."""
Expand Down