Skip to content

Unify device_state_attributes handling for Homematic IP Cloud#26449

Merged
MartinHjelmare merged 5 commits into
home-assistant:devfrom
SukramJ:HmIP_reorgDSA
Sep 6, 2019
Merged

Unify device_state_attributes handling for Homematic IP Cloud#26449
MartinHjelmare merged 5 commits into
home-assistant:devfrom
SukramJ:HmIP_reorgDSA

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Sep 5, 2019

Breaking Change:

The naming of entity attributes has been corrected (missing underscore) to follow the standards:

  • moisture detected --> moisture_detected
  • motion detected --> motion_detected
  • power mains failure --> power_mains_failure
  • presence detected --> presence_detected
  • smoke detector alarm --> smoke_detector_alarm
  • water level detected --> water_level_detected
  • window state --> window_state

Description:

PR #26103 changed the handling of device_state_attributes for devices.
This PR

  • uses the same simplifications for groups
  • unifies the handling with evice_state_attributes
  • remove checks for sabotage

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@SukramJ SukramJ changed the title Unifi device_state_attributes handling for Homematic IP Cloud groups Unifi device_state_attributes handling for Homematic IP Cloud Sep 5, 2019
@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Sep 5, 2019

Hi @MartinHjelmare, please have a look at this PR.
Thanks.

Comment thread homeassistant/components/homematicip_cloud/binary_sensor.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when a breaking change paragraph is added to the PR description.

@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Sep 6, 2019

Thanks a lot @MartinHjelmare,
the breaking change paragraph is added.

@MartinHjelmare MartinHjelmare changed the title Unifi device_state_attributes handling for Homematic IP Cloud Unify device_state_attributes handling for Homematic IP Cloud Sep 6, 2019
@MartinHjelmare MartinHjelmare merged commit f540d74 into home-assistant:dev Sep 6, 2019
@SukramJ SukramJ deleted the HmIP_reorgDSA branch September 6, 2019 13:59
@lock lock Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants