Skip to content

Add support for warning attributes to Homematic IP Cloud#26103

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
SukramJ:HmIP-OptionalFeatures
Aug 21, 2019
Merged

Add support for warning attributes to Homematic IP Cloud#26103
MartinHjelmare merged 2 commits into
home-assistant:devfrom
SukramJ:HmIP-OptionalFeatures

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Aug 21, 2019

Description:

This PR adds warning attributs (overheated, overloaded and undervoltaged) to HmIP entities.
This warnings are also displayed with an alert icon.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the development checklist

@SukramJ SukramJ changed the title Add supported for warning attributes to Homematic IP Cloud Add support for warning attributes to Homematic IP Cloud Aug 21, 2019
Comment thread homeassistant/components/homematicip_cloud/device.py Outdated
Comment thread homeassistant/components/homematicip_cloud/device.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit f80c9c9 into home-assistant:dev Aug 21, 2019
@SukramJ SukramJ deleted the HmIP-OptionalFeatures branch August 21, 2019 15:21
@lock lock Bot locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants