Skip to content

Fix polling HomeKit devices with multiple services per accessory #25629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jc2k merged 2 commits into from
Aug 1, 2019
Merged

Fix polling HomeKit devices with multiple services per accessory #25629

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e99f55c
Fix polling HomeKit devices with multiple services per accessory
Jc2k Aug 1, 2019
46f5bd5
Update homeassistant/components/homekit_controller/__init__.py
Jc2k Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions homeassistant/components/homekit_controller/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,21 @@ def async_state_changed(self):
"""Collect new data from bridge and update the entity state in hass."""
accessory_state = self._accessory.current_state.get(self._aid, {})
for iid, result in accessory_state.items():
# No value so dont process this result
if "value" not in result:
continue

# Unknown iid - this is probably for a sibling service that is part
# of the same physical accessory. Ignore it.
if iid not in self._char_names:
continue

# Callback to update the entity with this characteristic value
char_name = escape_characteristic_name(self._char_names[iid])
update_fn = getattr(self, "_update_{}".format(char_name), None)
if not update_fn:
continue

# pylint: disable=not-callable
update_fn(result["value"])

Expand Down